Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument Hanami using dry-monitor #910

Closed
2 of 3 tasks
luismiramirez opened this issue Jan 10, 2023 · 2 comments · Fixed by #996
Closed
2 of 3 tasks

Instrument Hanami using dry-monitor #910

luismiramirez opened this issue Jan 10, 2023 · 2 comments · Fixed by #996
Assignees

Comments

@luismiramirez
Copy link
Member

luismiramirez commented Jan 10, 2023

Timebox: 1 day (for research)

As mentioned by Peter Solnica in this toot, Hanami 2 uses dry-monitor by default. A gem like ActiveSupport::Notifications to monitor and instrument in Ruby.

The current integration is made by monkey patching Hanami::Action. Using dry-monitor would allow us to remove such monkey patch.

To do

- [ ] Add a listener for dry-monitor to our Ruby gem
- [ ] Test the data that is reported is useful, and report back if we are missing some data to Peter
- [ ] If we have enough data, ship the dry-monitor listener

  • Add a hook for dry-monitor instrumentation
  • Format rom-sql events that go through dry-monitor
  • Update documentation
@luismiramirez
Copy link
Member Author

The dry-monitor rack instrumentation doesn't provide all the data we need.

Added a hook for dry-monitor similar to the one we have for ActiveSupport::Notifications and native support for rom-sql events.

@tombruijn
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants