banner page job should ignore the page-set attribute

[michaelrsweet]

Version: 1.1.22
CUPS.org User: david.gelphman

A page-set attribute of 'even' is causing the banner page to be skipped because it is an odd page. The fix is to, like number-up and other attributes, ignore the page-set attribute if the job is the banner_page job.

Here are the changes to the Apple source I'm making:

RCS file: /cvs/root/cups/scheduler/job.c,v
retrieving revision 1.42
diff -u -d -b -w -r1.42 job.c
--- job.c 2004/10/30 02:47:50 1.42
+++ job.c 2004/11/05 01:00:49
@@ -1453,7 +1453,9 @@

   if ((strcmp(attr->name, "page-label") == 0 ||
        strcmp(attr->name, "page-border") == 0 ||

•       strncmp(attr->name, "number-up", 9) == 0) &&
  

•       strncmp(attr->name, "number-up", 9) == 0 ||
  

•       strncmp(attr->name, "page-set", 8) == 0
  

•      ) &&
    banner_page)
   continue;
  

[michaelrsweet]

CUPS.org User: mike

Reassigning to 1.2, will fix it there...

Thanks!

[michaelrsweet]

CUPS.org User: mike

Including with the 1.1.23 security update.

BTW, use strcmp() for page-set; the number-up, number-up-layout, etc. options are the only ones that need strncmp()...

[michaelrsweet]

CUPS.org User: mike

Fixed in CVS - the anonymous CVS repository will be updated at midnight EST.