Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters of Digest Header not comma separated #882

Closed
michaelrsweet opened this issue Sep 7, 2004 · 2 comments
Closed

Parameters of Digest Header not comma separated #882

michaelrsweet opened this issue Sep 7, 2004 · 2 comments

Comments

@michaelrsweet
Copy link
Collaborator

Version: 1.1.21rc2
CUPS.org User: sefftinge.lohndirekt

when the server asks for a digest authentication the parameters aren't comma separated.
It looks like this:
WWW-Authenticate: Digest realm="CUPS" nonce="127.0.0.1"

But has to look like this:
WWW-Authenticate: Digest realm="CUPS", nonce="127.0.0.1"

I think this patch helps (not tested!):

Index: client.c

RCS file: /home/anoncvs/cups/scheduler/client.c,v
retrieving revision 1.192
diff -r1.192 client.c
2123c2123

< if (httpPrintf(HTTP(con), "WWW-Authenticate: Digest realm="CUPS" "

  if (httpPrintf(HTTP(con), "WWW-Authenticate: Digest realm=\"CUPS\", "
@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

Reassigned to 1.1.x.

Looks like the RFC uses it in the examples but doesn't specify the comma or whitespace in the ABNF definition... Will check to see what the correct implementation should be...

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

OK, got clarification from the HTTP working group, and you are correct that the commas are required.

Fixed in CVS for 1.1.21rc3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant