Scheduler doesn't pick up printer state reasons from ipp backend

[michaelrsweet]

Version: 1.1.21rc1
CUPS.org User: mclasen.redhat

The ipp backend seems to be the only one which tries to report printer state back to the scheduler. It does so by writing lines like

STATE: toner-low-warning,developer-empty-error

to stderr. The scheduler picks that up and feeds the string to SetPrinterStateReasons(). That function seems to accept three kinds of
input:

+reason1,reason2,... for adding reasons to the set of current reasons
-reason1,reason2,... for removing reasons from the set of current reasons
reason1,reason2,... for replacing the set of current reasons

the first two seem to work fine, but the third one (which is what the
ipp backend uses) doesn't. To fix it, you have to remove the
s[0] == '+' condition from the if in printers.c:1745. Patch attached.

[michaelrsweet]

CUPS.org User: mike

Thanks, will apply the patch for the 1.1.21 release.

[michaelrsweet]

CUPS.org User: mike

Fixed in CVS - the anonymous CVS repository will be updated at midnight EST.

[michaelrsweet]

"state.diff":

--- cups-1.1.21rc1/scheduler/printers.c.state 2004-06-04 11:45:38.000000000 -0400
+++ cups-1.1.21rc1/scheduler/printers.c 2004-06-04 11:46:02.000000000 -0400
@@ -1742,8 +1742,7 @@
i --;
}
}

• else if (s[0] == '+' &&

•         p->num_reasons < (int)(sizeof(p->reasons) / sizeof(p->reasons[0])))
  

• else if (p->num_reasons < (int)(sizeof(p->reasons) / sizeof(p->reasons[0])))
  {
  /*
• Add reason...