Samba and Win9x: user is passed all upper-case and not authenticated

[michaelrsweet]

Version: 1.1.20
CUPS.org User: zoltan.sekeres.caseconsult

We use CUPS in conjunction with Samba 3.0.2 and Win9x (sigh). All users are required to be member of a specific group to be able to print.

As of the current CVS version (1.227) of scheduler/ipp.c a case sensitive check of the correct group membership is performed in function check_quotas (line 1976):

      for (j = 0; grp->gr_mem[j]; j ++)
        if (!strcmp(username, grp->gr_mem[j]))
          break;

Unfortunately Win9x reports the username all uppercase, so the above check fails. To correct this the group membership should be checked case insensitive:

      for (j = 0; grp->gr_mem[j]; j ++)
        if (!strcasecmp(username, grp->gr_mem[j]))
          break;

A few lines below there is already a case insensitive username check, so this should be ok. I've already applied the change successfully on our server.

It would be great if this change could be applied to the official version. Migration projects with Win9x boxes would benefit from this.

Thanks,
Zoltan

[michaelrsweet]

CUPS.org User: mike

We will look into this, and if it does not cause problems elsewhere will add this to 1.1.21 and 1.2.

[michaelrsweet]

CUPS.org User: mike

Fixed in CVS - the anonymous CVS repository will be updated at midnight EST.