Compile of CUPS 1.3.x fails when upgrading from CUPS 1.2

[michaelrsweet]

Version: 1.3.2
CUPS.org User: cmt

When compiling CUPS 1.3.x as an upgrade (installed CUPS 1.2.x), compile fails in cgi-bin/ with undefined symbols (first one is CUPS_SERVER_REMOTE_ANY in cgi-bin/admin.c).
This is caused by an error in the ordering of compiler arguments, the old headers in /usr/local/include get precedence over the current ones in cups' source directory. When assembling ALL_CFLAGS in Makedefs, $(CFLAGS)
has to go before $(SSLFLAGS). See attached file for a patch.
NOTE: this has been first discoverd on FreeBSD, see http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/116721 for reference.

[michaelrsweet]

CUPS.org User: mike

Fixed in Subversion repository.

[michaelrsweet]

"patch-Makedefs.in":

--- Makedefs.in.orig Fri Sep 28 21:13:27 2007
+++ Makedefs.in Fri Sep 28 21:13:48 2007
@@ -108,8 +108,8 @@

for extra debug info)

-ALL_CFLAGS = $(SSLFLAGS) @LARGEFILE@ @PTHREAD_FLAGS@ \

•       $(OPTIONS) $(CFLAGS)
  

  +ALL_CFLAGS = $(CFLAGS) $(SSLFLAGS) @LARGEFILE@ @PTHREAD_FLAGS@ \

•       $(OPTIONS)
  

  ARCHFLAGS = @ARCHFLAGS@
  ARFLAGS = @ARFLAGS@
  BACKLIBS = @BACKLIBS@