notify-recipient-uri is not recognized in a subscription request

[michaelrsweet]

Version: 1.2.8
CUPS.org User: dsharov

'notify-recipient-uri' is not recognized by scheduler for IPP_CREATE_JOB_SUBSCRIPTION and IPP_CREATE_PRINTER_SUBSCRIPTION requests.
This triggers scheduler to reject subscription request with 'client-error-bad-request' error in case 'push' notification method is requested (for ex. mailto).

Additional information:
Scheduler looks up recipient uri under 'notify-recipient' (non-standard) attribute.

subscription request submitted:
Create-Printer-Subscription = (
operation-attributes-tag = (
attributes-charset = 'utf-8' of charset,
attributes-natural-language = 'en_US' of naturalLanguage,
printer-uri = 'ipp://localhost:631/' of uri,
requesting-user-name = 'user' of nameWithoutLanguage
),
subscription-attributes-tag = (
notify-events = '(printer-added)' of array of keyword,
notify-lease-duration = '0' of integer,
notify-recipient-uri = 'mailto:test@test.user' of uri
)
)

subscription response received:
Response = (
status = client-error-bad-request,
operation-attributes-tag = (
attributes-charset = 'utf-8' of charset,
attributes-natural-language = 'en-us' of naturalLanguage
)
)

cups/error_log:
...
D [19/Mar/2007:13:32:23 +0200] cupsdReadClient: 12 POST / HTTP/1.1
D [19/Mar/2007:13:32:23 +0200] cupsdReadClient: 12 Browser asked for language "en.utf-8"...
D [19/Mar/2007:13:32:23 +0200] cupsdAuthorize: No authentication data provided.
D [19/Mar/2007:13:32:23 +0200] Create-Printer-Subscription ipp://localhost:631/
D [19/Mar/2007:13:32:23 +0200] cupsdCreateSubscription(con=0x813200(12), uri="ipp://localhost:631/")
D [19/Mar/2007:13:32:23 +0200] notify-lease-duration=0
D [19/Mar/2007:13:32:23 +0200] notify-time-interval=0
I [19/Mar/2007:13:32:23 +0200] Saving subscriptions.conf...
D [19/Mar/2007:13:32:23 +0200] cupsdProcessIPPRequest: 12 status_code=400 (client-error-bad-request)
D [19/Mar/2007:13:32:23 +0200] cupsdCloseClient: 12
...

[michaelrsweet]

CUPS.org User: mike

Fixed in Subversion repository.

The attached patch fixes things (ignore the admin.c reject when patching 1.2.x - that's the new RSS subscription stuff in the web interface...)