lpoptions crashes when adding/removing options and there are no printers

[michaelrsweet]

Version: 1.2-current
CUPS.org User: mike

The lpoptions command currently does not handle the "no printers" case when adding or removing options.

[michaelrsweet]

CUPS.org User: mike

Fixed in Subversion repository.

[michaelrsweet]

"str2295.patch":

Index: lpoptions.c

--- lpoptions.c (revision 6342)
+++ lpoptions.c (working copy)
@@ -174,6 +174,9 @@
if ((dest = cupsGetDest(NULL, NULL, num_dests, dests)) == NULL)
dest = dests;

•     if (dest == NULL)
  

•   _cupsLangPuts(stderr, _("lpoptions: No printers!?!\n"));
  

  • for (j = 0; j < dest->num_options; j ++)
    

    if (cupsGetOption(dest->options[j].name, num_options, options) == NULL)
    num_options = cupsAddOption(dest->options[j].name,
    @@ -244,6 +247,9 @@
    if ((dest = cupsGetDest(NULL, NULL, num_dests, dests)) == NULL)
    dest = dests;

•     if (dest == NULL)
  

•   _cupsLangPuts(stderr, _("lpoptions: No printers!?!\n"));
  

  • for (j = 0; j < dest->num_options; j ++)
    

    if (cupsGetOption(dest->options[j].name, num_options, options) == NULL)
    num_options = cupsAddOption(dest->options[j].name,