Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cupsd crash in get_jobs #2288

Closed
michaelrsweet opened this issue Mar 13, 2007 · 2 comments
Closed

cupsd crash in get_jobs #2288

michaelrsweet opened this issue Mar 13, 2007 · 2 comments
Milestone

Comments

@michaelrsweet
Copy link
Collaborator

Version: 1.2.8
CUPS.org User: twaugh.redhat

In get_jobs when my-jobs is set, we compare the job username before it is loaded. Patch attached.

Original bug report:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231522

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

Fixed in Subversion repository.

@michaelrsweet
Copy link
Collaborator Author

"cups-get_jobs.patch":

--- cups-1.2.8/scheduler/ipp.c.get_jobs 2007-03-13 14:26:39.000000000 +0000
+++ cups-1.2.8/scheduler/ipp.c 2007-03-13 14:26:41.000000000 +0000
@@ -5912,9 +5912,6 @@
if ((job->dtype & dmask) != dtype &&
(!job->printer || (job->printer->type & dmask) != dtype))
continue;

  • if (username[0] && strcasecmp(username, job->username))

- continue;

 if (completed && job->state_value <= IPP_JOB_STOPPED)
   continue;

@@ -5926,6 +5923,9 @@
if (!job->attrs)
continue;

  • if (username[0] && strcasecmp(username, job->username))
  •  continue;
    
    if (count > 0)
    ippAddSeparator(con->response);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant