Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cached remote printers not timed out with "Browsing Off" #2198

Closed
michaelrsweet opened this issue Jan 17, 2007 · 2 comments
Closed

Cached remote printers not timed out with "Browsing Off" #2198

michaelrsweet opened this issue Jan 17, 2007 · 2 comments

Comments

@michaelrsweet
Copy link
Collaborator

Version: 1.2.7
CUPS.org User: twaugh.redhat

When Browsing is changed from 'On' to 'Off' and cupsd is restarted, the printers previously browsed are reloaded from remote.cache and not timed out, even after waiting for the BrowseTimeout.

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

OK, looks like the fix for STR #2084 was incomplete - cupsdLoadRemoteCache() didn't check the Browsing setting, just BrowseRemoteProtocols...

See attached patch...

@michaelrsweet
Copy link
Collaborator Author

"str2198.patch":

Index: dirsvc.c

--- dirsvc.c (revision 6197)
+++ dirsvc.c (working copy)
@@ -163,7 +163,7 @@

  • Don't load the cache if the CUPS remote protocol is disabled...
    */
  • if (!(BrowseRemoteProtocols & BROWSE_CUPS))
  • if (!Browsing || !(BrowseRemoteProtocols & BROWSE_CUPS))
    {
    cupsdLogMessage(CUPSD_LOG_DEBUG,
    "cupsdLoadRemoteCache: Not loading remote cache.");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant