cover page after produces no cover page and disables n-up and page set for print job

[michaelrsweet]

Version: 1.2-current
CUPS.org User: david.gelphman

using cups 1.2, choosing cover page, to be printed after the job in Mac print panel correctly produces a job-sheets value of "none,standard". However cups 1.2 doesn't generate the banner page at all and the print job itself has its n-up and page-set settings set to default values.

[michaelrsweet]

CUPS.org User: mike

Can you attach an error_log file with debug enabled?

Thanks!

[michaelrsweet]

CUPS.org User: mike

OK, found the problem.

It was caused by the refactoring of the print_job() code in scheduler/ipp.c - basically, all of the common job submission code was moved out, but the trailing banner page code was not updated to get its own copy of the job-sheets attribute...

Patch attached.

[michaelrsweet]

CUPS.org User: mike

Secondary patch to address showpage redefinition now that we pass the job in one long stream...

[michaelrsweet]

"str1698.patch":

Index: ipp.c

--- ipp.c (revision 5551)
+++ ipp.c (working copy)
@@ -6828,8 +6828,10 @@

• See if we need to add the ending sheet...
  */
• attr = ippFindAttribute(job->attrs, "job-sheets", IPP_TAG_NAME);

if (!(printer->type & (CUPS_PRINTER_REMOTE | CUPS_PRINTER_IMPLICIT)) &&

•  attr->num_values > 1)
  

•  attr && attr->num_values > 1)
  

  {
  /*
  • Yes...

[michaelrsweet]

"str1698p2.patch":

Index: pstops.c

--- pstops.c (revision 5566)
+++ pstops.c (working copy)
@@ -891,6 +891,13 @@
}

/*

• * Restore the old showpage operator as needed...
• */

• if (doc->use_ESPshowpage)
• puts("userdict/showpage/ESPshowpage load put\n");

• /*
  • Write/copy the trailer...
    */

@@ -1065,6 +1072,13 @@
}
}
}
+

• /*
• * Restore the old showpage operator as needed...
• */

• if (doc->use_ESPshowpage)
• puts("userdict/showpage/ESPshowpage load put\n");
  }