Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible /dev/null corruption by log rotate #1651

Closed
michaelrsweet opened this issue May 2, 2006 · 1 comment
Closed

Possible /dev/null corruption by log rotate #1651

michaelrsweet opened this issue May 2, 2006 · 1 comment

Comments

@michaelrsweet
Copy link
Collaborator

Version: 1.1-current
CUPS.org User: martinz

If a log file points to /dev/null, this device will sooner or later become corrupted by cups.

The change of file permissions and ownership is prevented in
log.c - check_log_file() for all "/dev/..." logfiles.
The log rotation is not disabled.

As the file size is held internally "/dev/null" will be renamed to
"/dev/null.O" and a new ordinary file "/dev/null" will be created, when the assumed file size reaches MaxLogSize.

I suggest to add the "/dev/ - check" to the log rotation conditions.

This also regards the 1.2 versions.

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

Fixed in Subversion repository.

Note that you can also use the directive with no value to disable the corresponding log, e.g.:

AccessLog

disables the access log stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant