Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'set-allowed-users' in web UI #1486

Closed
michaelrsweet opened this issue Mar 14, 2006 · 2 comments
Closed

Fix 'set-allowed-users' in web UI #1486

michaelrsweet opened this issue Mar 14, 2006 · 2 comments

Comments

@michaelrsweet
Copy link
Collaborator

Version: 1.2b2
CUPS.org User: twaugh.redhat

Trying to set the allowed users list for a printer appears to succeed (no error reported) but the changes don't stick. Patch attached.

@michaelrsweet
Copy link
Collaborator Author

"cups-users.patch":

--- cups-1.2b2/cgi-bin/admin.c.users 2006-03-14 12:17:55.000000000 +0000
+++ cups-1.2b2/cgi-bin/admin.c 2006-03-14 12:32:01.000000000 +0000
@@ -2624,11 +2624,11 @@
NULL, uri);

 if (num_users == 0)
  •  ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
    
  •  ippAddString(request, IPP_TAG_PRINTER, IPP_TAG_NAME,
                "requesting-user-name-allowed", NULL, "all");
    

    else
    {

  •  attr = ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
    
  •  attr = ippAddStrings(request, IPP_TAG_PRINTER, IPP_TAG_NAME,
                        type, num_users, NULL, NULL);
    

    for (i = 0, ptr = (char *)users; *ptr; i ++)

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

Fixed in Subversion repository.

Thanks!

@michaelrsweet michaelrsweet added this to the Stable milestone Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant