Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread-safe libcups #1276

Closed
michaelrsweet opened this issue Sep 20, 2005 · 3 comments
Closed

Thread-safe libcups #1276

michaelrsweet opened this issue Sep 20, 2005 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@michaelrsweet
Copy link
Collaborator

Version: 1.2-feature
CUPS.org User: jlovell

I couldn't find the old STR requesting the thread safety feature so here's a new one. The attached patch is one way to skin this cat...

The before & after test to make sure you get them all is:

$ nm libcups.2.dylib | egrep -i " b|d "

It also fixes a typo in cupsd.conf.in and stops the compiler from complaining about -fpie (which is different than -fPIC?)

It touches a bunch of files -- sorry in advance for the formatting issues.

Thanks!

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

Your patch is missing the cups-threads.m4 file...

Will do some cleanup and commit, thanks!

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: jlovell

File attached now. I'm sure you can do better on the autoconf stuff.
I'm also not enamored with the variable names I choose in case you have thoughts on improvements.

Thanks!

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

Fixed in Subversion repository.

Please let me know if I've missed anything, particularly with the pthreads check (which I committed before I saw your file...)

I'll probably update the pthreads tests to handle more possibilities, but the current test is taken from the FLTK configure tests and works on *BSD, OSX, Linux, and all of the commercial UNIX's...

@michaelrsweet michaelrsweet added the enhancement New feature or request label Mar 17, 2016
@michaelrsweet michaelrsweet added this to the Stable milestone Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant