cupsaddsmb doesn't accept strong passwords

[michaelrsweet]

Version: 1.1-current
CUPS.org User: heisters

My samba admin user has a password with a single quote in it. Because of the way the password is sent to samba, the quote messes up parsing:

Running command: smbclient //localhost/print$ -N -U'smbadmin%'' -c 'mkdir W32X86;put /var/spool/cups/tmp/42f221d06746a W32X86/liblab.ppd;put /usr/share/cups/drivers/ps5ui.dll W32X86/ps5ui.dll;put /usr/share/cups/drivers/pscript.hlp W32X86/pscript.hlp;put /usr/share/cups/drivers/pscript.ntf W32X86/pscript.ntf;put /usr/share/cups/drivers/pscript5.dll W32X86/pscript5.dll'
sh: -c: line 0: unexpected EOF while looking for matching `''
sh: -c: line 1: syntax error: unexpected end of file

If it were possible to pass the password on the command line (which I see is a requested feature) it might be possible to manually URI encode the quote so this wouldn't occur.

[michaelrsweet]

CUPS.org User: mike

Hmm, we'll need to add a shell escape mechanism or just use fork() + exec() to bypass those issues. This won't be fixed until CUPS 1.2...

[michaelrsweet]

CUPS.org User: mike

Fixed in Subversion repository.