Close every fd on detaching

[michaelrsweet]

Version: 1.2-feature
CUPS.org User: kssingvo.suse

We noticed a bug in a different program (= not cupsd), where fds (= sockets) became not closed, before exec'ing cupsd. So the problem was that cupsd kept those fds open till he died. This was not good, because restarting the other application caused errors that it could not grap a special port.

So I'm asking for the following change: in file cups/scheduler/main.c

old:
if (fg < 1)
{
[...]
close(0);
close(1);
close(2);

new:
if (fg < 1)
{
int i;
int maxfd = getdtablesize();
[...]
for (i = 0; i < maxfd; i++)
close(fd);

[michaelrsweet]

CUPS.org User: mike

Sounds harmless enough; will look into adding this to CUPS 1.2.

[michaelrsweet]

CUPS.org User: mike

Fixed in Subversion repository.

Instead of using getdtablesize(), I used the current FD limit from getrlimit() which is more portable.