Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] berkeley/lpc.c does not behave like real BSD lpc #1004

Closed
michaelrsweet opened this issue Nov 15, 2004 · 3 comments
Closed

[patch] berkeley/lpc.c does not behave like real BSD lpc #1004

michaelrsweet opened this issue Nov 15, 2004 · 3 comments
Milestone

Comments

@michaelrsweet
Copy link
Collaborator

Version: 1.2-current
CUPS.org User: nardin.inf.ufsc

cups' lpc compatibility command does not understand the 'status all' subcommand of real BSD systems' lpc, treating 'all' as a printer name. Therefore, running 'lpc status all' shows nothing.
This makes software that relies on this (standard) behavior to get a list of printers (like the FreeBSD native Java port), to report no printers available when using cups' lpr compatibility commands.

The attached file is a patch against berkeley/lpc.c to correct this.

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

Reassigned to 1.2.

"lpc status all" is a relatively new additional - older OS's did not support it (or at least it was undocumented...)

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

Fixed in Subversion repository.

@michaelrsweet
Copy link
Collaborator Author

"cups-lpr__lpc.c__status_all.diff":

--- berkeley/lpc.c.orig Wed Feb 25 17:14:50 2004
+++ berkeley/lpc.c Mon Nov 15 17:54:38 2004
@@ -339,6 +339,15 @@
}

  /*
  •  \* A single 'all' printer name is special, meaning all printers.
    
  •  */
    
  •  if (dests != NULL && compare_strings(dests, "all", 3) == 0)
    
  •  {
    
  •    dests = NULL;
    
  •  }
    
  • /*
    
    • See if this is a printer we're interested in...
      */

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant