Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Check config sending 0 instead of null as of v0.2.0-beta.0 #737

Closed
EverlastingBugstopper opened this issue Aug 16, 2021 · 0 comments · Fixed by #738
Closed

bug: Check config sending 0 instead of null as of v0.2.0-beta.0 #737

EverlastingBugstopper opened this issue Aug 16, 2021 · 0 comments · Fixed by #738
Assignees
@EverlastingBugstopper
Labels
bug 🐞
Milestone
v0.2.0

Comments

@EverlastingBugstopper
Copy link
Contributor

Any time a number is sent alongside a check operation, Apollo Studio will override the default configuration, even if the number is 0. As of this commit, Rover is sending 0 by default instead of null, which cause operation checks to run over 0 time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EverlastingBugstopper EverlastingBugstopper

Labels
bug 🐞
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

fix(rover-client): properly send validation period config apollographql/rover
1 participant
@EverlastingBugstopper