Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rover 0.1.9 build failure #696

Closed
chenrui333 opened this issue Jul 29, 2021 · 5 comments · Fixed by #697
Closed

rover 0.1.9 build failure #696

chenrui333 opened this issue Jul 29, 2021 · 5 comments · Fixed by #697
Assignees
Labels
api 💬 related to registry API changes bug 🐞

Comments

@chenrui333
Copy link

Seeing the build failure when building rover 0.1.9 release.

   Compiling rover-client v0.0.0 (/private/tmp/rover-20210729-36326-1s3qx43/rover-0.1.9/crates/rover-client)
error[E0308]: mismatched types
  --> crates/rover-client/src/query/subgraph/publish.rs:68:8
   |
68 |     Ok(service_data.upsert_implementing_service_and_trigger_composition)
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct `PublishPartialSchemaMutationServiceUpsertImplementingServiceAndTriggerComposition`, found enum `std::option::Option`
   |
   = note: expected struct `PublishPartialSchemaMutationServiceUpsertImplementingServiceAndTriggerComposition`
                found enum `std::option::Option<PublishPartialSchemaMutationServiceUpsertImplementingServiceAndTriggerComposition>`
@chenrui333 chenrui333 added bug 🐞 triage issues and PRs that need to be triaged labels Jul 29, 2021
@EverlastingBugstopper
Copy link
Contributor

This is broken on main as well today. This seems to be due to a change to Apollo's API upstream. Will investigate this today, thanks for the report!

@EverlastingBugstopper EverlastingBugstopper added api 💬 related to registry API changes and removed triage issues and PRs that need to be triaged labels Jul 29, 2021
@EverlastingBugstopper EverlastingBugstopper linked a pull request Jul 29, 2021 that will close this issue
@chenrui333
Copy link
Author

Thanks @EverlastingBugstopper!

@chenrui333
Copy link
Author

thanks @EverlastingBugstopper for the quick fix! any chance that the team would make a quick patch release? Thanks!

@EverlastingBugstopper
Copy link
Contributor

We'll be releasing v0.2.0 after we receive some more feedback on structured output. For now, if you clone this repo and run cargo xtask dist --version v0.1.9 then it will build a version of Rover for you using the types from an older GraphQL schema in your local target directory.

This was referenced Aug 5, 2021
@chenrui333
Copy link
Author

rover 0.1.10 is good, thanks @EverlastingBugstopper!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api 💬 related to registry API changes bug 🐞
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants