Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rover supergraph: query latest composition errors #499

Open
lrlna opened this issue May 3, 2021 · 2 comments
Open

rover supergraph: query latest composition errors #499

lrlna opened this issue May 3, 2021 · 2 comments
Labels
feature 🎉 new commands, flags, functionality, and improved error messages needs design ✏️

Comments

@lrlna
Copy link
Member

lrlna commented May 3, 2021

Description

Providing we are not able to successfully run rover supergraph fetch, this feature should allow to get a few of the latest composition errors from the registry in a local environment. This was brought up in #485.

Things to think about:

  • what should this command look like?
  • does this API endpoint already exist, or does the registry need to be built?
  • does studio already show these, and should we try to echo a similar output to the studio?
@lrlna lrlna added feature 🎉 new commands, flags, functionality, and improved error messages triage issues and PRs that need to be triaged labels May 3, 2021
@EverlastingBugstopper EverlastingBugstopper added this to the June 22 milestone May 5, 2021
@lrlna lrlna removed the triage issues and PRs that need to be triaged label May 5, 2021
@EverlastingBugstopper
Copy link
Contributor

what should this command look like?

idk... maybe like rover supergraph fetch --latest or something? not sure on this one. it's a bit of a different paradigm than the rest of our commands

does this API endpoint already exist, or does the registry need to be built?

it is already built, and we fetch it already as part of the work on #485

does studio already show these, and should we try to echo a similar output to the studio?

yeah, you can get there by clicking on a federated graph, and then up at the top there's a federated button with a red X on it if composition is broken. It looks pretty much exactly how the rest of our composition errors look

image

@abernix
Copy link
Member

abernix commented Jun 9, 2021

See related #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🎉 new commands, flags, functionality, and improved error messages needs design ✏️
Projects
None yet
Development

No branches or pull requests

3 participants