Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: "Welcome to Rover" on first command run #202

Closed
EverlastingBugstopper opened this issue Jan 25, 2021 · 2 comments · Fixed by #303
Closed

RFC: "Welcome to Rover" on first command run #202

EverlastingBugstopper opened this issue Jan 25, 2021 · 2 comments · Fixed by #303
Assignees
Labels
feature 🎉 new commands, flags, functionality, and improved error messages needs decision 🤝
Milestone

Comments

@EverlastingBugstopper
Copy link
Contributor

Most of our commands require authentication! Maybe when we run any rover command while unauthenticated, we shouldn't even print like it's an error! Let's just welcome them to Rover:

$ rover subgraph fetch mygraph-i-know-exists > mygraph.sdl
Hi! I'm Rover, it looks like you're new here.

To authenticate, please head on over to https://studio.apollographql.com to grab your API key, and then run `rover config profile auth`.
@EverlastingBugstopper EverlastingBugstopper added feature 🎉 new commands, flags, functionality, and improved error messages needs decision 🤝 labels Jan 25, 2021
@EverlastingBugstopper EverlastingBugstopper added this to the 🐣 0.1.0 milestone Jan 25, 2021
@JakeDawkins
Copy link
Contributor

Ah yeah! I love that. Rather than making an http request and printing out something ugly, we could definitely print a friendlier message first

A future improvement could be to somehow automatically run config auth when another command that needs auth is run

like:

$ rover subgraph fetch mygraph-i-know-exists > mygraph.sdl
Hi! I'm Rover, it looks like you're new here.

This command requires you be authenticaed with Apollo Studio!
Go to https://studio.apollographql.com/user-settings and create a new Personal API Key.

Copy the key and paste it into the prompt below.
> 

@JakeDawkins
Copy link
Contributor

I'll tackle this first message though, just as a quick improvement :)

@JakeDawkins JakeDawkins self-assigned this Feb 22, 2021
@JakeDawkins JakeDawkins linked a pull request Feb 23, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🎉 new commands, flags, functionality, and improved error messages needs decision 🤝
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants