-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: rover update
#159
Comments
I am wondering if we should model this API after
How would you feel about the above tweaks? I really like the idea of |
love it. i think that approach is much better! |
A note: this flow should perhaps also include 'install from a commit sha' flow. But for this we can do point people to checkout the commit and run |
I'm proposing that we add a
rover update
that automatically updates the binary to the latest version. There are a few decisions to be made about its behavior that I'll outline below.got some pseudocode here for what i think a good behavior pattern would be for this command.
rover update
behaviorrover update --beta
would look very similar to the above except it would never update to a stable release, instead always trying to update to the latest stable release and returning an error if it couldn't find anything newerrover update --version v1.0.0
(equivalent to--version 1.0.0
or at least letting you know to prefix with av
) would let you install a specific version of rover and error if it could not find that versionrover update list
would list all of the available releases to update tothe
update_exe
fn from above is pretty much implemented already inbinstall
so the work here is primarily around deciding if the default behavior i've lined out is OK in addition to some GitHub API queries.The text was updated successfully, but these errors were encountered: