Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request param to didEncounter method #3193

Closed
kamila-brylewska-zendesk opened this issue Dec 16, 2024 · 1 comment
Closed

Add request param to didEncounter method #3193

kamila-brylewska-zendesk opened this issue Dec 16, 2024 · 1 comment

Comments

@kamila-brylewska-zendesk
Copy link
Contributor

Hello :)
I want to provide more information to didEncounterError method in RemoteGraphQLDataSource class.

During implementation of didEncounterError I noticed I didn't have enough information about subgraph request. As far as I know context is the same for all subgraph requests. Adding parameter request (type GatewayGraphQLRequest) would allow me to get more information about request with error.

this.didEncounterError(error, fetchRequest, fetchResponse, context, request);

I prepared PR to show you my idea more clearly. Thank you in advance!

@kamila-brylewska-zendesk
Copy link
Contributor Author

My PR: #3194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants