Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQLErrorOptions not supported by graphql < 16.5 in 2.1.0-alpha.1 or higher #2049

Closed
benweatherman opened this issue Aug 8, 2022 · 0 comments · Fixed by #2060
Closed
Labels
Milestone

Comments

@benweatherman
Copy link
Contributor

benweatherman commented Aug 8, 2022

At least with some versions of graphql@16, there's a build error

$ tsc
node_modules/@apollo/federation-internals/dist/error.d.ts:1:33 - error TS2305: Module '"graphql"' has no exported member 'GraphQLErrorOptions'.

1 import { ASTNode, GraphQLError, GraphQLErrorOptions, GraphQLFormattedError } from "graphql";
                                  ~~~~~~~~~~~~~~~~~~~

Found 1 error in node_modules/@apollo/federation-internals/dist/error.d.ts:1

This was introduced with an error cleanup #1914. GraphQLErrorOptions was introduced in graphql@16.5.0 https://github.com/graphql/graphql-js/releases/tag/v16.5.0

This was happening with graphql@16.3.0. Updating to graphql@16.5.0 fixes it.

@benweatherman benweatherman changed the title GraphQLErrorOptions not supported by graphql@^16.0.0 GraphQLErrorOptions not supported by graphql@^16.0.0 in 2.1.0-alpha.1 or higher Aug 8, 2022
@benweatherman benweatherman added this to the 2.1.0 milestone Aug 8, 2022
@benweatherman benweatherman changed the title GraphQLErrorOptions not supported by graphql@^16.0.0 in 2.1.0-alpha.1 or higher GraphQLErrorOptions not supported by graphql < 16.5 in 2.1.0-alpha.1 or higher Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant