Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deliver: @defer support in the query planner #1921

Closed
pcmanus opened this issue Jun 21, 2022 · 1 comment · Fixed by #1958
Closed

Deliver: @defer support in the query planner #1921

pcmanus opened this issue Jun 21, 2022 · 1 comment · Fixed by #1958
Assignees

Comments

@pcmanus
Copy link
Contributor

pcmanus commented Jun 21, 2022

We can implement some support for the upcoming @defer graphQL directive in the query planner by using entities keys. This will only work for a @defer that applies at the level of an entity, but this feel plenty useful: it sounds likely that a fair number of uses for @defer are going to align well with entities.

This ticket is for tracking the implementation of such entity-based @defer support in the query planner. Additional support for @defer could be later provided by passing the remaining non-entity-based defers down to subgraphs supporting it, but this should be considered out of scope for this issue. It also make sense that support for @stream be added along the same logic, but this need not be in the scope of this issue either.

@pcmanus pcmanus self-assigned this Jun 21, 2022
@jeffjakub jeffjakub changed the title @defer support in the query planner Deliver: @defer support in the query planner Jul 21, 2022
@pcmanus
Copy link
Contributor Author

pcmanus commented Aug 31, 2022

Forgot to updates this earlier, but the bulk of this work was merged (and released) with #1958 so closing this issue.

@pcmanus pcmanus closed this as completed Aug 31, 2022
@pcmanus pcmanus linked a pull request Aug 31, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants