Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Wrong generated global type file import (Typescript) #557

Closed
stnwk opened this issue Aug 21, 2018 · 5 comments
Closed

Bug: Wrong generated global type file import (Typescript) #557

stnwk opened this issue Aug 21, 2018 · 5 comments

Comments

@stnwk
Copy link
Contributor

stnwk commented Aug 21, 2018

Hi everyone :)

Since apollographql/rover#520 by @danilobuerger landed I noticed the following:

When a globalTypes.ts file is generated and the the --outputFlat option is used, the outputPath is being ignored in generated type files (at least for the import statement of the globalTypes file).

It outputs:

import { SomeGlobalTypes, ShouldBe, Here } from "globalTypes";

when it should really be:

import { SomeGlobalTypes, ShouldBe, Here } from "./globalTypes";

Notice the incorrect path in the first example.

If you need more details, please let me know!

@stnwk stnwk changed the title Bug: Wrong generated global type file import Bug: Wrong generated global type file import (Typescript) Aug 21, 2018
@danilobuerger
Copy link
Contributor

Duplicate of #543, fixed in #544

@lirbank
Copy link

lirbank commented Aug 22, 2018

Yeah, this has been fixed a while ago (12 days ago) but it has not yet been published.

@shadaj is there anything preventing a new release? Would be awesome to have the fix published.

@shadaj
Copy link
Contributor

shadaj commented Aug 23, 2018

v1.7.1 has been published with the latest fixes included! Apologies for the late release, I just started college this week so my schedule's been packed with orientation activities.

@shadaj shadaj closed this as completed Aug 23, 2018
@stnwk
Copy link
Contributor Author

stnwk commented Aug 23, 2018

Thank you!

@johannesnagl
Copy link

I just started college this week so my schedule's been packed with orientation activities

@shadaj all the best for your college years! Have fun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants