Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passthrough of options to graphql playground disabled #1290

Closed
ashtonsix opened this issue Jul 3, 2018 · 2 comments
Closed

Passthrough of options to graphql playground disabled #1290

ashtonsix opened this issue Jul 3, 2018 · 2 comments

Comments

@ashtonsix
Copy link

This commit 84233d2 broke my code, so I'm staying at rc.5 until fixed:

const graphqlConfigPath = path.resolve(__dirname, '../.graphqlconfig')
const graphqlConfig = JSON.parse(fs.readFileSync(graphqlConfigPath, 'utf8'))
server.applyMiddleware({app, gui: {config: graphqlConfig}})

The graphql config is very important for me because it lets me work with multiple APIs & environments simulaneously.

@evans
Copy link
Contributor

evans commented Jul 10, 2018

@ashtonsix Thank you for opening the issue! We're most likely going to place the code in #1297 inside of the ApolloServer constructor, so that apollo-server can update them. If you have any feedback, please feel free to weight in

@evans
Copy link
Contributor

evans commented Jul 17, 2018

With #1297, we can now specify a playground.config 🎉

@evans evans closed this as completed Jul 17, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants