From a17c4beb0d524fb9ff160abf69cef74c06a3ffed Mon Sep 17 00:00:00 2001 From: Jesse Rosenberger Date: Fri, 26 Jun 2020 15:32:13 +0000 Subject: [PATCH] tests(op-reg): Use shared `EngineReportingOptions`. These are all meant to be the same in all cases. --- ...polloServerPluginOperationRegistry.test.ts | 30 +++++++------------ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/packages/apollo-server-plugin-operation-registry/src/__tests__/ApolloServerPluginOperationRegistry.test.ts b/packages/apollo-server-plugin-operation-registry/src/__tests__/ApolloServerPluginOperationRegistry.test.ts index 009b96a230e..881ccaf1870 100644 --- a/packages/apollo-server-plugin-operation-registry/src/__tests__/ApolloServerPluginOperationRegistry.test.ts +++ b/packages/apollo-server-plugin-operation-registry/src/__tests__/ApolloServerPluginOperationRegistry.test.ts @@ -21,6 +21,7 @@ import { } from './helpers.test-helpers'; import { Headers } from 'apollo-server-env'; import { GraphQLRequest } from 'apollo-server-plugin-base'; +import { EngineReportingOptions } from 'apollo-engine-reporting'; // While not ideal, today, Apollo Server has a very real expectation of an HTTP // request context. That will change in the future. While we can sometimes @@ -51,6 +52,10 @@ describe('Operation registry plugin', () => { const graphId = 'test-service'; const apiKey = `service:${graphId}:not-an-api-key`; const hashedApiKey = hashApiKey(apiKey); + const engineOptions: EngineReportingOptions = { + apiKey, + sendReportsImmediately: true, + }; const typeDefs = gql` type Query { hello: String @@ -88,10 +93,7 @@ describe('Operation registry plugin', () => { const server = new ApolloServerMock({ typeDefs, mockEntireSchema: true, - engine: { - apiKey, - sendReportsImmediately: true, - }, + engine: engineOptions, plugins: [ plugin({ onUnregisteredOperation, @@ -141,10 +143,7 @@ describe('Operation registry plugin', () => { const server = new ApolloServerMock({ typeDefs, mockEntireSchema: true, - engine: { - apiKey, - sendReportsImmediately: true, - }, + engine: engineOptions, plugins: [ plugin({ onUnregisteredOperation, @@ -180,10 +179,7 @@ describe('Operation registry plugin', () => { const server = new ApolloServerMock({ typeDefs, mockEntireSchema: true, - engine: { - apiKey, - sendReportsImmediately: true, - }, + engine: engineOptions, plugins: [ plugin({ forbidUnregisteredOperations, @@ -236,10 +232,7 @@ describe('Operation registry plugin', () => { const server = new ApolloServerMock({ typeDefs, mockEntireSchema: true, - engine: { - apiKey, - sendReportsImmediately: true, - }, + engine: engineOptions, plugins: [ plugin({ forbidUnregisteredOperations, @@ -277,10 +270,7 @@ describe('Operation registry plugin', () => { const server = new ApolloServerMock({ typeDefs, mockEntireSchema: true, - engine: { - apiKey, - sendReportsImmediately: true, - }, + engine: engineOptions, plugins: [ plugin({ onForbiddenOperation,