Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate partialRefetch #7967

Open
brainkim opened this issue Apr 9, 2021 · 2 comments
Open

Deprecate partialRefetch #7967

brainkim opened this issue Apr 9, 2021 · 2 comments
Labels

Comments

@brainkim
Copy link
Contributor

brainkim commented Apr 9, 2021

While investigating #7861, and after a conversation with @benjamn, I’ve learned that the partialRefetch option for useQuery might be a candidate for deprecation. The reasoning is that fetch policies are more consistently applied in Apollo 3, and for instance, the cache-first fetch policy will actually refetch missing fields automatically.

This issue is to track adding a deprecation warning for when people set partialRefetch to true. We can add it in 3.4 or later, and remove it in 4.0.

Additionally, we can use this issue to track documentation changes (they recommend setting this option to true and that false is the legacy), which I have been told is strictly false.

We can also use this issue to field objections from the community, should they exist. If you are using partialRefetch, we’d like to hear from you.

@hwillson
Copy link
Member

@brainkim @benjamn based on our 4.0 discussion today, this issue is likely going to go away (after the React layer rewrite). I'll flag this for 4.0 as a reminder.

@hwillson hwillson added this to the Release 4.0 milestone May 12, 2021
@hwillson hwillson removed this from the v4.0 - Planned milestone Jul 9, 2021
@hwillson hwillson added the 🔍 investigate Investigate further label May 31, 2022
@kainosnoema
Copy link

fwiw @hwillson @benjamn we're still seeing regular scenarios in the latest release where partial cache can cause data to be undefined and not be refetched, even with a cache policy of cache-first. Setting partialRefetch: true seems to resolve the issue. I'm not sure how to work around these issues if this option is deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants