Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve node queries directly from store #79

Closed
stubailo opened this issue Apr 6, 2016 · 2 comments
Closed

Resolve node queries directly from store #79

stubailo opened this issue Apr 6, 2016 · 2 comments

Comments

@stubailo
Copy link
Contributor

stubailo commented Apr 6, 2016

When we have a query like:

{
  node(id: "1") {
    __typename,
    id,
    ... on Person {
      name
    }
  }
}

If we already have a node with ID 1 in the store, we should be able to retrieve it. Right now, this will not realize that this is just looking for a particular node, and hit the network with a new root query. I guess this also means, when we receive the result of a root node query, we might want to not cache it under the root query, but instead only under the ID of the node.

@stubailo stubailo assigned stubailo and unassigned stubailo Apr 7, 2016
@stubailo stubailo added this to the alpha milestone Apr 7, 2016
@stubailo
Copy link
Contributor Author

stubailo commented Apr 8, 2016

This will become important once fragment variables are a thing. But isn't as useful now.

@stubailo stubailo removed this from the alpha milestone Apr 9, 2016
@stubailo
Copy link
Contributor Author

Could be implemented using #26

@stubailo stubailo closed this as completed May 5, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant