Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After 1.2.1 release can't build the project. #4537

Closed
kruszyk opened this issue Mar 5, 2019 · 7 comments
Closed

After 1.2.1 release can't build the project. #4537

kruszyk opened this issue Mar 5, 2019 · 7 comments

Comments

@kruszyk
Copy link

kruszyk commented Mar 5, 2019

Intended outcome:

Intended outcome : project builds.

I am using Apollo in my Angular 6 project. 6 days ago it stops compiling,

Actual outcome:

Actual outcome: Project fails to build. Error I am getting is 👍

ERROR in node_modules/apollo-cache-inmemory/node_modules/apollo-utilities/lib/util/mergeDeep.d.ts(2,52): error TS2370: A rest parameter must be of an array type.

How to reproduce the issue:

Not sure how to reproduce it. In my case it was working one day and it stopped next day without any changes. I guess apollo-utilities library went from 1.1.3 to 1.2.1

Versions

System:
OS: Linux 3.10 CentOS Linux 7 (Core)
Binaries:
Node: 8.9.4 - /usr/local/bin/node
npm: 5.6.0 - /usr/local/bin/npm
Browsers:
Chrome: 72.0.3626.121
Firefox: 60.5.1
npmPackages:
apollo-angular: ^1.5.0 => 1.5.0
apollo-angular-link-http: ^1.5.0 => 1.5.0
apollo-cache-inmemory: ^1.4.3 => 1.4.3
apollo-client: ^2.4.13 => 2.4.13
apollo-link: ^1.2.8 => 1.2.8

@pl12133
Copy link

pl12133 commented Mar 5, 2019

Which version of typescript are you running? Upgrading your versions may help resolve the issue, please see #4506 (comment).

@cheungyinglon
Copy link

+1

@kruszyk
Copy link
Author

kruszyk commented Mar 6, 2019

@pl12133

I am building project with 2.9.2, which is highest I can go I believe.

@darmie
Copy link

darmie commented Mar 6, 2019

I am having this problem too

@niklasR
Copy link

niklasR commented Mar 6, 2019

I'm also experiencing this With TS 2.9.2, however on another machine it seems to work with utilities 1.2.1 and TS 2.9.2.. Continuing investigation.

@darmie
Copy link

darmie commented Mar 6, 2019

This fixed it for me.

#4501 (comment)

@benjamn
Copy link
Member

benjamn commented Mar 6, 2019

Duplicate of #4506 (and also #4501).

@benjamn benjamn closed this as completed Mar 6, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants