From a444e58cea27e14ce4c4f2053b0322dcd532d0fa Mon Sep 17 00:00:00 2001 From: Umidbek Karimov Date: Thu, 20 Dec 2018 20:30:29 +0500 Subject: [PATCH] fix(ApolloClient): Pass `TVariables` to `ObservableQuery` in `watchQuery`. (#4253) --- packages/apollo-client/src/ApolloClient.ts | 4 ++-- packages/apollo-client/src/core/QueryManager.ts | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/apollo-client/src/ApolloClient.ts b/packages/apollo-client/src/ApolloClient.ts index 6f9863b226b..f99975b1f7e 100644 --- a/packages/apollo-client/src/ApolloClient.ts +++ b/packages/apollo-client/src/ApolloClient.ts @@ -239,7 +239,7 @@ export default class ApolloClient implements DataProxy { */ public watchQuery( options: WatchQueryOptions, - ): ObservableQuery { + ): ObservableQuery { if (this.defaultOptions.watchQuery) { options = { ...this.defaultOptions.watchQuery, @@ -256,7 +256,7 @@ export default class ApolloClient implements DataProxy { options = { ...options, fetchPolicy: 'cache-first' }; } - return this.initQueryManager().watchQuery(options); + return this.initQueryManager().watchQuery(options); } /** diff --git a/packages/apollo-client/src/core/QueryManager.ts b/packages/apollo-client/src/core/QueryManager.ts index 0f2239a256d..e27bd50a2d2 100644 --- a/packages/apollo-client/src/core/QueryManager.ts +++ b/packages/apollo-client/src/core/QueryManager.ts @@ -640,10 +640,10 @@ export class QueryManager { // supposed to be refetched in the event of a store reset. Once we unify error handling for // network errors and non-network errors, the shouldSubscribe option will go away. - public watchQuery( + public watchQuery( options: WatchQueryOptions, shouldSubscribe = true, - ): ObservableQuery { + ): ObservableQuery { if (options.fetchPolicy === 'standby') { throw new Error( 'client.watchQuery cannot be called with fetchPolicy set to "standby"', @@ -667,9 +667,9 @@ export class QueryManager { options.notifyOnNetworkStatusChange = false; } - let transformedOptions = { ...options } as WatchQueryOptions; + let transformedOptions = { ...options } as WatchQueryOptions; - return new ObservableQuery({ + return new ObservableQuery({ scheduler: this.scheduler, options: transformedOptions, shouldSubscribe: shouldSubscribe,