Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(additional-properties): add typed additional properties support for models #106

Merged
merged 15 commits into from
Nov 28, 2024

Conversation

sufyankhanrao
Copy link
Collaborator

@sufyankhanrao sufyankhanrao commented Nov 13, 2024

What

This PR adds the handling for the typed additional properties in serialization (form and JSON) and de-serialization. Also, contains the tests for the newly added changes.

Why

To add support for the typed additional properties in the SDK

Closes #105

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

…for models

This commit adds the handling for the typed additional properties in serialization (form and JSON) and de-serialization. Also, contains the tests for the newly added changes.
@sufyankhanrao sufyankhanrao self-assigned this Nov 13, 2024
@sufyankhanrao sufyankhanrao marked this pull request as draft November 13, 2024 21:30
@sufyankhanrao sufyankhanrao marked this pull request as ready for review November 14, 2024 12:20
Copy link
Contributor

@hamzamahmood hamzamahmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the comments in the PR before it can be merged and released.

Copy link
Contributor

@haseeb-mhr haseeb-mhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hamzamahmood hamzamahmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamzamahmood hamzamahmood merged commit bbfcb62 into main Nov 28, 2024
8 checks passed
@hamzamahmood hamzamahmood deleted the 105-add-typed-additional-propery-support branch November 28, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for typed additional properties
3 participants