Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(release): add automated release action with lerna #173

Merged
merged 3 commits into from
May 28, 2024
Merged

ci(release): add automated release action with lerna #173

merged 3 commits into from
May 28, 2024

Conversation

hamzamahmood
Copy link
Collaborator

@hamzamahmood hamzamahmood commented May 23, 2024 •
edited by usamabintariq
Loading

This PR resolves several key concerns:

  • Introducing versioning and npm publishing capabilities for apimatic-js-runtime packages using Lerna
  • Establishing GitHub Releases alongside package tags for enhanced visibility
  • Implementing commitlint to enforce adherence to commitlint guidelines, ensuring consistency in commits.

Closes #172

@hamzamahmood
ci(release): add automated release action with lerna
9edc898 
- add commitlint to only allow commits that follow commitlint rules

Closes #173
@hamzamahmood hamzamahmood added the enhancement New feature or request label May 23, 2024
@hamzamahmood hamzamahmood self-assigned this May 23, 2024
asadali214
asadali214 previously approved these changes May 23, 2024
View reviewed changes
MaryamAdnan3
MaryamAdnan3 previously approved these changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@MaryamAdnan3 MaryamAdnan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamzamahmood hamzamahmood dismissed stale reviews from MaryamAdnan3 and asadali214 via 5f81644 May 28, 2024 05:41
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hamzamahmood hamzamahmood merged commit 82f9536 into master May 28, 2024
10 checks passed
@asadali214 asadali214 deleted the 172-automated-ts-release branch July 19, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asadali214 asadali214 asadali214 approved these changes

@MaryamAdnan3 MaryamAdnan3 MaryamAdnan3 left review comments

Assignees

@hamzamahmood hamzamahmood

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance Automated Package Versioning and Publishing with Lerna
3 participants
@hamzamahmood @asadali214 @MaryamAdnan3