Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nullable-headers): adds the capability to set null headers in request builder #171

Merged
merged 2 commits into from
May 22, 2024
Merged

fix(nullable-headers): adds the capability to set null headers in request builder #171

merged 2 commits into from
May 22, 2024

Conversation

asadali214
Copy link
Collaborator

This PR adds the capability in the requestBuilder's instance to also accept header value null

Before

header(name: string, value?: string | boolean | number | bigint)

After

header(name: string, value?: string | boolean | number | bigint | null)

@asadali214 asadali214 added the bug Something isn't working label May 22, 2024
@asadali214 asadali214 requested a review from hamzamahmood May 22, 2024 06:08
@asadali214 asadali214 self-assigned this May 22, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

hamzamahmood
hamzamahmood approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@hamzamahmood hamzamahmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@asadali214 asadali214 merged commit 817211f into master May 22, 2024
10 checks passed
@asadali214 asadali214 deleted the nullable-request-builder-opts branch May 22, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamzamahmood hamzamahmood hamzamahmood approved these changes

Assignees

@asadali214 asadali214

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asadali214 @hamzamahmood