Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auto-refresh-fetch): enable auto refresh and fetch oauth token flow #162

Merged
merged 3 commits into from
Apr 9, 2024
Merged

feat(auto-refresh-fetch): enable auto refresh and fetch oauth token flow #162

merged 3 commits into from
Apr 9, 2024

Conversation

asadali214
Copy link
Collaborator

This PR adds the functionality i.e. a provider to fetch or refresh the OAuth token again, whenever it meets the following criteria:

  • It gets expired
  • It is undefined

This PR also adds the functionality to get updated OAuthToken via a callback function that can be used to store it wherever necessary

Closes #161

@asadali214 asadali214 added the enhancement New feature or request label Apr 9, 2024
@asadali214 asadali214 self-assigned this Apr 9, 2024
@asadali214 asadali214 linked an issue Apr 9, 2024 that may be closed by this pull request
[oauth-adapters] Enable auto fetching for OAuthToken #161
Closed
@asadali214 asadali214 force-pushed the 161-auto-fetch-oauth-flow branch from 263ab59 to 6a4e84f Compare April 9, 2024 04:49
MaryamAdnan3
MaryamAdnan3 previously approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@MaryamAdnan3 MaryamAdnan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thehappybug
thehappybug requested changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@thehappybug thehappybug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check out my feedback on the code.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@asadali214 asadali214 merged commit a8da229 into master Apr 9, 2024
10 checks passed
@asadali214 asadali214 deleted the 161-auto-fetch-oauth-flow branch April 9, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehappybug thehappybug thehappybug approved these changes

@MaryamAdnan3 MaryamAdnan3 Awaiting requested review from MaryamAdnan3

Assignees

@asadali214 asadali214

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[oauth-adapters] Enable auto fetching for OAuthToken
3 participants
@asadali214 @thehappybug @MaryamAdnan3