From 190541da9979e243dc0b6579103b6fb5b18dff1b Mon Sep 17 00:00:00 2001 From: shamrickus Date: Wed, 4 Aug 2021 08:20:26 -0600 Subject: [PATCH 1/2] Fix indices --- CHANGELOG.md | 1 + .../2021080408053529_fix_indices.down.sql | 22 +++++++++++++++++++ .../2021080408053529_fix_indices.up.sql | 22 +++++++++++++++++++ 3 files changed, 45 insertions(+) create mode 100644 traffic_ops/app/db/migrations/2021080408053529_fix_indices.down.sql create mode 100644 traffic_ops/app/db/migrations/2021080408053529_fix_indices.up.sql diff --git a/CHANGELOG.md b/CHANGELOG.md index ad3881fedb..1ff86fb9e9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -95,6 +95,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - [#5981](https://github.com/apache/trafficcontrol/issues/5891) - `/deliveryservices/{{ID}}/safe` returns incorrect response for the requested API version - [#5984](https://github.com/apache/trafficcontrol/issues/5894) - `/servers/{{ID}}/deliveryservices` returns incorrect response for the requested API version - [#6027](https://github.com/apache/trafficcontrol/issues/6027) - Collapsed DB migrations +- [#6066](https://github.com/apache/trafficcontrol/issues/6066) - Fixed missing/incorrect indices on some tables ### Changed - Updated the Traffic Ops Python client to 3.0 diff --git a/traffic_ops/app/db/migrations/2021080408053529_fix_indices.down.sql b/traffic_ops/app/db/migrations/2021080408053529_fix_indices.down.sql new file mode 100644 index 0000000000..a961aa447e --- /dev/null +++ b/traffic_ops/app/db/migrations/2021080408053529_fix_indices.down.sql @@ -0,0 +1,22 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ + +ALTER INDEX IF EXISTS phys_location_last_updated_idx RENAME TO pys_location_last_updated_idx; + +DROP INDEX IF EXISTS topology_last_updated_idx; + +CREATE INDEX IF NOT EXISTS topology_last_updated_idx ON topology_cachegroup (last_updated DESC NULLS LAST); diff --git a/traffic_ops/app/db/migrations/2021080408053529_fix_indices.up.sql b/traffic_ops/app/db/migrations/2021080408053529_fix_indices.up.sql new file mode 100644 index 0000000000..01c7c45105 --- /dev/null +++ b/traffic_ops/app/db/migrations/2021080408053529_fix_indices.up.sql @@ -0,0 +1,22 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ + +ALTER INDEX IF EXISTS pys_location_last_updated_idx RENAME TO phys_location_last_updated_idx; + +DROP INDEX IF EXISTS topology_last_updated_idx; + +CREATE INDEX IF NOT EXISTS topology_last_updated_idx ON topology (last_updated DESC NULLS LAST); From 8b575cc314b8ccc75193f04978ebd9b2230b4cea Mon Sep 17 00:00:00 2001 From: shamrickus Date: Wed, 4 Aug 2021 12:22:41 -0600 Subject: [PATCH 2/2] Fail on conflict/missing --- .../app/db/migrations/2021080408053529_fix_indices.down.sql | 6 +++--- .../app/db/migrations/2021080408053529_fix_indices.up.sql | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/traffic_ops/app/db/migrations/2021080408053529_fix_indices.down.sql b/traffic_ops/app/db/migrations/2021080408053529_fix_indices.down.sql index a961aa447e..031a2549c3 100644 --- a/traffic_ops/app/db/migrations/2021080408053529_fix_indices.down.sql +++ b/traffic_ops/app/db/migrations/2021080408053529_fix_indices.down.sql @@ -15,8 +15,8 @@ * the License. */ -ALTER INDEX IF EXISTS phys_location_last_updated_idx RENAME TO pys_location_last_updated_idx; +ALTER INDEX phys_location_last_updated_idx RENAME TO pys_location_last_updated_idx; -DROP INDEX IF EXISTS topology_last_updated_idx; +DROP INDEX topology_last_updated_idx; -CREATE INDEX IF NOT EXISTS topology_last_updated_idx ON topology_cachegroup (last_updated DESC NULLS LAST); +CREATE INDEX topology_last_updated_idx ON topology_cachegroup (last_updated DESC NULLS LAST); diff --git a/traffic_ops/app/db/migrations/2021080408053529_fix_indices.up.sql b/traffic_ops/app/db/migrations/2021080408053529_fix_indices.up.sql index 01c7c45105..ed0ea5599d 100644 --- a/traffic_ops/app/db/migrations/2021080408053529_fix_indices.up.sql +++ b/traffic_ops/app/db/migrations/2021080408053529_fix_indices.up.sql @@ -15,8 +15,8 @@ * the License. */ -ALTER INDEX IF EXISTS pys_location_last_updated_idx RENAME TO phys_location_last_updated_idx; +ALTER INDEX pys_location_last_updated_idx RENAME TO phys_location_last_updated_idx; -DROP INDEX IF EXISTS topology_last_updated_idx; +DROP INDEX topology_last_updated_idx; -CREATE INDEX IF NOT EXISTS topology_last_updated_idx ON topology (last_updated DESC NULLS LAST); +CREATE INDEX topology_last_updated_idx ON topology (last_updated DESC NULLS LAST);