Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Goose #3342

Closed
rob05c opened this issue Feb 20, 2019 · 2 comments · Fixed by #6057
Closed

Remove Goose #3342

rob05c opened this issue Feb 20, 2019 · 2 comments · Fixed by #6057
Assignees
Labels
database relating to setup/installation/structure of the Traffic Ops database dependencies Pull requests that update a dependency file improvement The functionality exists but it could be improved in some way. tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops

Comments

@rob05c
Copy link
Member

rob05c commented Feb 20, 2019

Traffic Ops uses Goose for database migration. Goose is unmaintained, and has been for years. We need to move to a maintained db migration tool. For security, bug fixes, ease of use, etc.

The most difficult part of this will be removing the 1 Go migration we have, which won't be supported by a generic SQL migration tool. It will need to be converted to real SQL. Alternatively, if we "squash" the migrations into the default seeds in a release, including that migration, that may solve the problem (or it may be equally difficult to squash).

@rob05c rob05c added the tech debt rework due to choosing easy/limited solution label Feb 20, 2019
@rawlinp
Copy link
Contributor

rawlinp commented Aug 19, 2019

The migrations were recently squashed, so the one Go migration we had is now gone.

@mitchell852 mitchell852 added the Traffic Ops related to Traffic Ops label Nov 18, 2019
@zrhoffman zrhoffman added database relating to setup/installation/structure of the Traffic Ops database dependencies Pull requests that update a dependency file labels Apr 1, 2021
@rawlinp
Copy link
Contributor

rawlinp commented Jun 28, 2021

Note: as of #5699, we are using a maintained fork of goose. However, it doesn't seem to be a very popular fork, so we'd probably still prefer to move off of goose altogether for something more popular.

@zrhoffman zrhoffman self-assigned this Jul 2, 2021
@zrhoffman zrhoffman added the improvement The functionality exists but it could be improved in some way. label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database relating to setup/installation/structure of the Traffic Ops database dependencies Pull requests that update a dependency file improvement The functionality exists but it could be improved in some way. tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants