Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context around added/removed pieces of CDN snapshot when doing a snapshot diff #1653

Closed
mitchell852 opened this issue Dec 12, 2017 · 0 comments · Fixed by #1658
Closed

Add context around added/removed pieces of CDN snapshot when doing a snapshot diff #1653

mitchell852 opened this issue Dec 12, 2017 · 0 comments · Fixed by #1658
Assignees
@mitchell852
Labels
new feature A new feature, capability or behavior Traffic Portal v1 related to Traffic Portal version 1
Milestone
2.2.0

Comments

@mitchell852
Copy link
Member

mitchell852 commented Dec 12, 2017 •
edited
Loading

Currently when you "diff" a CDN snapshot (crconfig.json) in Traffic Portal (current snapshot vs new snapshot), you have 2 options:

  1. See everything (unchanged parts, added parts, removed parts)
  2. See only change parts (added parts and removed parts)

This is configurable in traffic_portal_properties.

No. 1 is great but it breaks down when the CRconfig.json gets really big. For example, our CRConfig.json is roughly 10 MB. The browser has a hard time digesting/displaying 10MB.

No. 2 is much smaller as it is only showing the changed parts.....but....you have no context for those items that were added/removed.

Need the ability to show some context around each added/removed piece kind of like github does with the diff view
@mitchell852 mitchell852 added improvement Traffic Portal v1 related to Traffic Portal version 1 labels Dec 12, 2017
@mitchell852 mitchell852 self-assigned this Dec 12, 2017
@mitchell852 mitchell852 mentioned this issue Dec 13, 2017
Merged
@mitchell852 mitchell852 changed the title Need context around added/removed pieces of CDN snapshot when doing a snapshot diff Add context around added/removed pieces of CDN snapshot when doing a snapshot diff Dec 14, 2017
@mitchell852 mitchell852 added this to the 2.2.0 milestone Jan 17, 2018
@rob05c rob05c added new feature A new feature, capability or behavior and removed improvement labels Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitchell852 mitchell852

Labels
new feature A new feature, capability or behavior Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Milestone
2.2.0
2 participants
@mitchell852 @rob05c