From d6af3dfefb3f0e402855c15fa9d4907924b00585 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Fri, 26 May 2023 14:32:01 -0600 Subject: [PATCH 1/6] feat(flags): enabling DASHBOARD_CROSS_FILTERS and DRILL_TO_DETAIL by default (board tasks 44, 46) --- superset/config.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/superset/config.py b/superset/config.py index a424a09d23d8c..6ab40157e62fb 100644 --- a/superset/config.py +++ b/superset/config.py @@ -446,7 +446,7 @@ class D3Format(TypedDict, total=False): # When True, this escapes HTML (rather than rendering it) in Markdown components "ESCAPE_MARKDOWN_HTML": False, "DASHBOARD_NATIVE_FILTERS": True, # deprecated - "DASHBOARD_CROSS_FILTERS": False, + "DASHBOARD_CROSS_FILTERS": True, # Feature is under active development and breaking changes are expected "DASHBOARD_NATIVE_FILTERS_SET": False, # deprecated "DASHBOARD_FILTERS_EXPERIMENTAL": False, # deprecated @@ -482,7 +482,7 @@ class D3Format(TypedDict, total=False): "CACHE_QUERY_BY_USER": False, # Enable sharing charts with embedding "EMBEDDABLE_CHARTS": True, - "DRILL_TO_DETAIL": False, + "DRILL_TO_DETAIL": True, "DRILL_BY": False, "DATAPANEL_CLOSED_BY_DEFAULT": False, "HORIZONTAL_FILTER_BAR": False, From 695ba042397ee7a97625736b50dd6b995094749c Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Fri, 26 May 2023 14:36:03 -0600 Subject: [PATCH 2/6] feat(flags): enabling and deprecating ENABLE_TEMPLATE_REMOVE_FILTERS, VERSIONED_EXPORT --- RESOURCES/FEATURE_FLAGS.md | 4 ++-- superset/config.py | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/RESOURCES/FEATURE_FLAGS.md b/RESOURCES/FEATURE_FLAGS.md index 5df7c0de718c3..f2263f1ee0674 100644 --- a/RESOURCES/FEATURE_FLAGS.md +++ b/RESOURCES/FEATURE_FLAGS.md @@ -28,7 +28,6 @@ These features are considered **unfinished** and should only be used on developm [//]: # "PLEASE KEEP THE LIST SORTED ALPHABETICALLY" - ENABLE_ADVANCED_DATA_TYPES -- ENABLE_TEMPLATE_REMOVE_FILTERS - KV_STORE - PRESTO_EXPAND_DATA - SHARE_QUERIES_VIA_KV_STORE @@ -56,7 +55,6 @@ These features are **finished** but currently being tested. They are usable, but - RLS_IN_SQLLAB - SSH_TUNNELING [(docs)](https://superset.apache.org/docs/installation/setup-ssh-tunneling) - USE_ANALAGOUS_COLORS -- VERSIONED_EXPORT ## Stable @@ -95,5 +93,7 @@ These features flags currently default to True and **will be removed in a future - DISABLE_DATASET_SOURCE_EDIT - ENABLE_EXPLORE_DRAG_AND_DROP - ENABLE_EXPLORE_JSON_CSRF_PROTECTION +- ENABLE_TEMPLATE_REMOVE_FILTERS - GENERIC_CHART_AXES - REMOVE_SLICE_LEVEL_LABEL_COLORS +- VERSIONED_EXPORT diff --git a/superset/config.py b/superset/config.py index 6ab40157e62fb..fcf225ef0c6f3 100644 --- a/superset/config.py +++ b/superset/config.py @@ -424,7 +424,8 @@ class D3Format(TypedDict, total=False): # See `PR 7935 `_ for more details. "ENABLE_EXPLORE_JSON_CSRF_PROTECTION": False, # deprecated "ENABLE_TEMPLATE_PROCESSING": False, - "ENABLE_TEMPLATE_REMOVE_FILTERS": False, + # ENABLE_TEMPLATE_REMOVE_FILTERS is deprecated and will be removed in a future major version + "ENABLE_TEMPLATE_REMOVE_FILTERS": True, # Allow for javascript controls components # this enables programmers to customize certain charts (like the # geospatial ones) by inputting javascript in controls. This exposes @@ -452,6 +453,7 @@ class D3Format(TypedDict, total=False): "DASHBOARD_FILTERS_EXPERIMENTAL": False, # deprecated "DASHBOARD_VIRTUALIZATION": False, "GLOBAL_ASYNC_QUERIES": False, + # VERSIONED_EXPORT is deprecated and will be removed in a future major version "VERSIONED_EXPORT": True, "EMBEDDED_SUPERSET": False, # Enables Alerts and reports new implementation From e3925503540211595bc151a862059cf565c8a2d6 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Fri, 26 May 2023 14:44:24 -0600 Subject: [PATCH 3/6] updating UPDATING --- UPDATING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UPDATING.md b/UPDATING.md index 15210cb7dcef8..3dd0c35732705 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -23,7 +23,7 @@ This file documents any backwards-incompatible changes in Superset and assists people when migrating to a new version. ## Next - +- [24232](https://github.com/apache/superset/pull/24232) Enables ENABLE_TEMPLATE_REMOVE_FILTERS, DRILL_TO_DETAIL, DASHBOARD_CROSS_FILTERS by default, marks VERSIONED_EXPORT and ENABLE_TEMPLATE_REMOVE_FILTERS as deprecated - [23652](https://github.com/apache/superset/pull/23652) Enables GENERIC_CHART_AXES feature flag by default. - [23226](https://github.com/apache/superset/pull/23226) Migrated endpoint `/estimate_query_cost/` to `/api/v1/sqllab/estimate/`. Corresponding permissions are can estimate query cost on SQLLab. Make sure you add/replace the necessary permissions on any custom roles you may have. - [22809](https://github.com/apache/superset/pull/22809): Migrated endpoint `/superset/sql_json` and `/superset/results/` to `/api/v1/sqllab/execute/` and `/api/v1/sqllab/results/` respectively. Corresponding permissions are `can sql_json on Superset` to `can execute on SQLLab`, `can results on Superset` to `can results on SQLLab`. Make sure you add/replace the necessary permissions on any custom roles you may have. From 8371923b405d5d8d9b15ada9d9a2fffaa3303fdb Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Fri, 26 May 2023 16:16:21 -0600 Subject: [PATCH 4/6] lint-y nits --- UPDATING.md | 2 +- superset/config.py | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/UPDATING.md b/UPDATING.md index 3dd0c35732705..c7e2ad3ffb86a 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -23,7 +23,7 @@ This file documents any backwards-incompatible changes in Superset and assists people when migrating to a new version. ## Next -- [24232](https://github.com/apache/superset/pull/24232) Enables ENABLE_TEMPLATE_REMOVE_FILTERS, DRILL_TO_DETAIL, DASHBOARD_CROSS_FILTERS by default, marks VERSIONED_EXPORT and ENABLE_TEMPLATE_REMOVE_FILTERS as deprecated +- [24232](https://github.com/apache/superset/pull/24232) Enables ENABLE_TEMPLATE_REMOVE_FILTERS, DRILL_TO_DETAIL, DASHBOARD_CROSS_FILTERS by default, marks VERSIONED_EXPORT and ENABLE_TEMPLATE_REMOVE_FILTERS as deprecated. - [23652](https://github.com/apache/superset/pull/23652) Enables GENERIC_CHART_AXES feature flag by default. - [23226](https://github.com/apache/superset/pull/23226) Migrated endpoint `/estimate_query_cost/` to `/api/v1/sqllab/estimate/`. Corresponding permissions are can estimate query cost on SQLLab. Make sure you add/replace the necessary permissions on any custom roles you may have. - [22809](https://github.com/apache/superset/pull/22809): Migrated endpoint `/superset/sql_json` and `/superset/results/` to `/api/v1/sqllab/execute/` and `/api/v1/sqllab/results/` respectively. Corresponding permissions are `can sql_json on Superset` to `can execute on SQLLab`, `can results on Superset` to `can results on SQLLab`. Make sure you add/replace the necessary permissions on any custom roles you may have. diff --git a/superset/config.py b/superset/config.py index fcf225ef0c6f3..659b31cd3b36c 100644 --- a/superset/config.py +++ b/superset/config.py @@ -424,7 +424,8 @@ class D3Format(TypedDict, total=False): # See `PR 7935 `_ for more details. "ENABLE_EXPLORE_JSON_CSRF_PROTECTION": False, # deprecated "ENABLE_TEMPLATE_PROCESSING": False, - # ENABLE_TEMPLATE_REMOVE_FILTERS is deprecated and will be removed in a future major version + # ENABLE_TEMPLATE_REMOVE_FILTERS is deprecated and + # will be removed in a future major version "ENABLE_TEMPLATE_REMOVE_FILTERS": True, # Allow for javascript controls components # this enables programmers to customize certain charts (like the From 5dc425f63ad8f8a46899bda24c16fab260081c3e Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Fri, 26 May 2023 16:20:38 -0600 Subject: [PATCH 5/6] oops, following convention now... --- superset/config.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/superset/config.py b/superset/config.py index 659b31cd3b36c..ed84e6a3e5bb4 100644 --- a/superset/config.py +++ b/superset/config.py @@ -424,9 +424,7 @@ class D3Format(TypedDict, total=False): # See `PR 7935 `_ for more details. "ENABLE_EXPLORE_JSON_CSRF_PROTECTION": False, # deprecated "ENABLE_TEMPLATE_PROCESSING": False, - # ENABLE_TEMPLATE_REMOVE_FILTERS is deprecated and - # will be removed in a future major version - "ENABLE_TEMPLATE_REMOVE_FILTERS": True, + "ENABLE_TEMPLATE_REMOVE_FILTERS": True, # deprecated # Allow for javascript controls components # this enables programmers to customize certain charts (like the # geospatial ones) by inputting javascript in controls. This exposes @@ -454,8 +452,7 @@ class D3Format(TypedDict, total=False): "DASHBOARD_FILTERS_EXPERIMENTAL": False, # deprecated "DASHBOARD_VIRTUALIZATION": False, "GLOBAL_ASYNC_QUERIES": False, - # VERSIONED_EXPORT is deprecated and will be removed in a future major version - "VERSIONED_EXPORT": True, + "VERSIONED_EXPORT": True, # deprecated "EMBEDDED_SUPERSET": False, # Enables Alerts and reports new implementation "ALERT_REPORTS": False, From b8882ed0c9603725016b94136654dd25a30f1016 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Tue, 30 May 2023 11:57:05 -0600 Subject: [PATCH 6/6] lint... --- superset/config.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/superset/config.py b/superset/config.py index ed84e6a3e5bb4..dc63146ca86e6 100644 --- a/superset/config.py +++ b/superset/config.py @@ -424,7 +424,7 @@ class D3Format(TypedDict, total=False): # See `PR 7935 `_ for more details. "ENABLE_EXPLORE_JSON_CSRF_PROTECTION": False, # deprecated "ENABLE_TEMPLATE_PROCESSING": False, - "ENABLE_TEMPLATE_REMOVE_FILTERS": True, # deprecated + "ENABLE_TEMPLATE_REMOVE_FILTERS": True, # deprecated # Allow for javascript controls components # this enables programmers to customize certain charts (like the # geospatial ones) by inputting javascript in controls. This exposes @@ -452,7 +452,7 @@ class D3Format(TypedDict, total=False): "DASHBOARD_FILTERS_EXPERIMENTAL": False, # deprecated "DASHBOARD_VIRTUALIZATION": False, "GLOBAL_ASYNC_QUERIES": False, - "VERSIONED_EXPORT": True, # deprecated + "VERSIONED_EXPORT": True, # deprecated "EMBEDDED_SUPERSET": False, # Enables Alerts and reports new implementation "ALERT_REPORTS": False,