diff --git a/superset-frontend/packages/superset-ui-core/src/time-format/TimeFormatterRegistrySingleton.ts b/superset-frontend/packages/superset-ui-core/src/time-format/TimeFormatterRegistrySingleton.ts index becab8441ce63..2eae7a41b50d0 100644 --- a/superset-frontend/packages/superset-ui-core/src/time-format/TimeFormatterRegistrySingleton.ts +++ b/superset-frontend/packages/superset-ui-core/src/time-format/TimeFormatterRegistrySingleton.ts @@ -84,7 +84,7 @@ export function getTimeFormatterForGranularity(granularity?: TimeGranularity) { export function formatTime( formatId: string | undefined, - value: Date | null | undefined, + value: Date | number | null | undefined, granularity?: TimeGranularity, ) { return getTimeFormatter(formatId, granularity)(value); diff --git a/superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-color/ColorPallettesStories.jsx b/superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-color/ColorPallettesStories.tsx similarity index 100% rename from superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-color/ColorPallettesStories.jsx rename to superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-color/ColorPallettesStories.tsx diff --git a/superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-color/RenderPalettes.jsx b/superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-color/RenderPalettes.tsx similarity index 100% rename from superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-color/RenderPalettes.jsx rename to superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-color/RenderPalettes.tsx diff --git a/superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-number-format/BigNumberStories.jsx b/superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-number-format/BigNumberStories.tsx similarity index 75% rename from superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-number-format/BigNumberStories.jsx rename to superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-number-format/BigNumberStories.tsx index a09920a620cf4..df57c4ad99142 100644 --- a/superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-number-format/BigNumberStories.jsx +++ b/superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-number-format/BigNumberStories.tsx @@ -17,41 +17,37 @@ * under the License. */ -/* eslint-disable jsx-a11y/label-has-associated-control */ import React from 'react'; import { formatNumber } from '@superset-ui/core'; -const propTypes = {}; -const defaultProps = {}; - class NumberFormatValidator extends React.PureComponent { + state: { formatString: string; testValues: (number | null | undefined)[] } = { + formatString: '.3~s', + testValues: [ + 987654321, + 12345.6789, + 3000, + 400.14, + 70.00002, + 1, + 0, + -1, + -70.00002, + -400.14, + -3000, + -12345.6789, + -987654321, + Number.POSITIVE_INFINITY, + Number.NEGATIVE_INFINITY, + NaN, + null, + undefined, + ], + }; + constructor(props) { super(props); - this.state = { - formatString: '.3~s', - testValues: [ - 987654321, - 12345.6789, - 3000, - 400.14, - 70.00002, - 1, - 0, - -1, - -70.00002, - -400.14, - -3000, - -12345.6789, - -987654321, - Number.POSITIVE_INFINITY, - Number.NEGATIVE_INFINITY, - NaN, - null, - undefined, - ], - }; - this.handleFormatChange = this.handleFormatChange.bind(this); } @@ -90,14 +86,17 @@ class NumberFormatValidator extends React.PureComponent {
{`${v}`}
{v instanceof Date ? v.toUTCString() : `${v}`}
@@ -122,9 +123,6 @@ class TimeFormatValidator extends React.PureComponent {
}
}
-TimeFormatValidator.propTypes = propTypes;
-TimeFormatValidator.defaultProps = defaultProps;
-
export default {
title: 'Core Packages/@superset-ui-time-format',
};