Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Already added slice(s) should be available/visible as checked in the 'Add Slices to dashboard' GUI. #3319

Closed
NaukhaizAhmad opened this issue Aug 17, 2017 · 9 comments

Comments

@NaukhaizAhmad
Copy link

NaukhaizAhmad commented Aug 17, 2017

Superset version

Latest Version (0.19.0)

Expected results

If a slice has been already added to a dashboard, then upon opening the add slice popup that added slice would be coming as selected.

Actual results

currently, all the slices in the add slices popup GUI are coming as deselected or unchecked.

Steps to reproduce

  • Create a dashboard
  • Go to add slices popup GUI
  • Add single or multiple slice(s) to the dashboard
  • Now again open the add slice pop up GUI, this time all the slices would be coming as unchecked/deselected.
@xrmx
Copy link
Contributor

xrmx commented Aug 17, 2017

What's latest version? Please use a release or a git hash

@NaukhaizAhmad
Copy link
Author

It's 0.18.2
Thanks.

@xrmx
Copy link
Contributor

xrmx commented Aug 17, 2017

Then 0.18.2 is not the latest version as now.

@NaukhaizAhmad
Copy link
Author

So, should i test it on the latest one first?

@NaukhaizAhmad NaukhaizAhmad changed the title Already added slice should be coming as checked in the 'Add Slices to dashboard' GUI. Already added slice should be available/visible as checked in the 'Add Slices to dashboard' GUI. Aug 17, 2017
@xrmx
Copy link
Contributor

xrmx commented Aug 17, 2017

It's better to report bugs againt latest release or latest master because they can be already be fixed.

@NaukhaizAhmad
Copy link
Author

Thanks, i'll verify this issue on the latest release.

@NaukhaizAhmad
Copy link
Author

This issue is still producing on version 0.19.0
Thanks.

@NaukhaizAhmad NaukhaizAhmad changed the title Already added slice should be available/visible as checked in the 'Add Slices to dashboard' GUI. Already added slice(s) should be available/visible as checked in the 'Add Slices to dashboard' GUI. Aug 17, 2017
@mistercrunch
Copy link
Member

Notice: this issue has been closed because it has been inactive for 248 days. Feel free to comment and request for this issue to be reopened.

@NaukhaizAhmad
Copy link
Author

This is a valid ticket, so please change its state to 'open'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants