Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to see public dashboards in Firefox anonymous session #14912

Closed
zufolo441 opened this issue May 29, 2021 · 12 comments
Closed

unable to see public dashboards in Firefox anonymous session #14912

zufolo441 opened this issue May 29, 2021 · 12 comments
Labels
authentication:RBAC Related to RBAC

Comments

@zufolo441
Copy link

zufolo441 commented May 29, 2021

Hi,
we have lots of dashboards publicly available. In config.py there is PUBLIC_ROLE_LIKE ="Gamma".
when I try to see them in anonymous session I obtain following error.
In normal session they work.
I tried the git version of yesterday too.
Schermata 2021-05-29 alle 08 37 31

@zufolo441 zufolo441 added the #bug Bug report label May 29, 2021
@junlincc junlincc added authentication:RBAC Related to RBAC and removed #bug Bug report labels Jun 1, 2021
@junlincc
Copy link
Member

junlincc commented Jun 1, 2021

@zufolo441 does it work in other browers?

cc @amitmiran137 @simcha90 you may know

@suddjian
Copy link
Member

suddjian commented Jun 1, 2021

Hi Francesco, could you please update the issue with the version of Superset that you're using?

@zufolo441
Copy link
Author

Hi, I tried with Chrome and works.
Version is from git: 4f5c537, but I tried version of 5 days ago too.

Thanks!

@zufolo441
Copy link
Author

I've just tried the actual version: a90e168 . Same problem.
Screenshot_20210607_085914

@lilila
Copy link

lilila commented Jun 17, 2021

I have the same problem, using superset 1.2rc2, with Chrome, Firefox and Safari (haven't tried other browser).
I have PUBLIC_ROLE_LIKE: Optional[str] = 'Gamma' and AUTH_ROLE_PUBLIC = 'Public' in config.py.

When not logged I can access the list of published dashboards but when I want to open one get the following error:
image

image

@villebro
Copy link
Member

Let me try to reproduce this

@aspedrosa
Copy link

I think I was able to find the source for the problem.
The information of the user present on the state is empty (Maybe saying something wrong related to react concepts 😅 ).

empty_user_on_state

At least its roles need to be present. Just to test I applied these changes to superset/views/utils.py

no_dashboard_on_public

@lilila
Copy link

lilila commented Jun 18, 2021

fantastic, thank you!

@zufolo441
Copy link
Author

For me, it didn't solve...
Screenshot_20210618_172146

@aussat
Copy link

aussat commented Jul 6, 2021

I experienced the same issue after upgrading to 1.2.0 (installed using pip). The solution above worked perfectly for me. @aspedrosa thanks a lot!

@suddjian
Copy link
Member

suddjian commented Jul 7, 2021

@aspedrosa great job! Would you mind opening a PR with your fix? I'd be happy to review and help get it merged.

@aspedrosa
Copy link

aspedrosa commented Jul 8, 2021

@zufolo441
image
The permissions I have on the public role

@suddjian sure 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication:RBAC Related to RBAC
Projects
None yet
Development

No branches or pull requests

8 participants