Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native filter] can not set filter scope: JS errors #14422

Closed
3 tasks done
graceguo-supercat opened this issue Apr 30, 2021 · 1 comment · Fixed by #14426
Closed
3 tasks done

[native filter] can not set filter scope: JS errors #14422

graceguo-supercat opened this issue Apr 30, 2021 · 1 comment · Fixed by #14426
Labels
#bug Bug report dashboard:native-filters Related to the native filters of the Dashboard P1 Priority item - Major

Comments

@graceguo-supercat
Copy link

How to reproduce the bug

  1. Enable native filter feature flag,
  2. open World Bank's Data dashboard,
  3. open filter bar, set filter scope for "country name", for example, remove scope for "%Rural" chart.
  4. Config panel has not response,
  5. If you open dev console, will see JS error thrown.

Screenshots

Screen Shot 2021-04-29 at 6 05 11 PM

Environment

latest master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@graceguo-supercat graceguo-supercat added #bug Bug report P0 Priority item - Critical labels Apr 30, 2021
@junlincc junlincc removed the P0 Priority item - Critical label Apr 30, 2021
@junlincc
Copy link
Member

junlincc commented Apr 30, 2021

Thanks for reporting, filter scoping is broken in master. should have been broken by one of our latest changes.
highest priority among all other filter polishing tasks
🙏 @villebro @kgabryje

Screen.Recording.2021-04-29.at.10.41.13.PM.mov

@junlincc junlincc added P1 Priority item - Major dashboard:native-filters Related to the native filters of the Dashboard labels Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report dashboard:native-filters Related to the native filters of the Dashboard P1 Priority item - Major
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants