From 45888eaa12ad6cf57c08ceaef3e6abd1cf01496b Mon Sep 17 00:00:00 2001 From: amitmiran137 Date: Mon, 9 Aug 2021 21:08:18 +0300 Subject: [PATCH] fix: typing difficulties --- superset/config.py | 3 +-- superset/tasks/cache.py | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/superset/config.py b/superset/config.py index a2bb590c4e1f3..2a4f7e4ac7b32 100644 --- a/superset/config.py +++ b/superset/config.py @@ -51,7 +51,6 @@ logger = logging.getLogger(__name__) if TYPE_CHECKING: - from tasks.cache import Strategy from flask_appbuilder.security.sqla import models # pylint: disable=unused-import from superset.connectors.sqla.models import ( # pylint: disable=unused-import @@ -706,7 +705,7 @@ class CeleryConfig: # pylint: disable=too-few-public-methods CELERY_CONFIG = CeleryConfig # pylint: disable=invalid-name # Additional Caching strategies to be used in the CELERYBEAT_SCHEDULE config -EXTRA_CACHING_STRATEGIES: List[Strategy] = [] +EXTRA_CACHING_STRATEGIES = [] # Set celery config to None to disable all the above configuration # CELERY_CONFIG = None diff --git a/superset/tasks/cache.py b/superset/tasks/cache.py index 56265d1e0a207..378a971956aaa 100644 --- a/superset/tasks/cache.py +++ b/superset/tasks/cache.py @@ -252,7 +252,7 @@ def get_urls(self) -> List[str]: return urls -strategies : List[Strategy] = [DummyStrategy, TopNDashboardsStrategy, DashboardTagsStrategy] +strategies = [DummyStrategy, TopNDashboardsStrategy, DashboardTagsStrategy] @celery_app.task(name="cache-warmup") @@ -268,7 +268,7 @@ def cache_warmup( logger.info("Loading strategy") class_ = None - extra_strategies: List[Strategy] = app.config["EXTRA_CACHING_STRATEGIES"] + extra_strategies = app.config["EXTRA_CACHING_STRATEGIES"] for class_ in strategies + extra_strategies: if class_.name == strategy_name: # type: ignore break