[SPARK-47261][SQL] Assign better name for errors _LEGACY_ERROR_TEMP_1172, _LEGACY_ERROR_TEMP_1173, and _LEGACY_ERROR_TEMP_1174 #47421
+52
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OR_TEMP_1173 Assign better name for error _LEGACY_ERROR_TEMP_1174
|
Hi @MaxGekk @cloud-fan , I raise a quick PR for https://issues.apache.org/jira/browse/SPARK-47261. Do you mind taking a quick look? Thanks. |
|
Hi @LuciferYang @yaooqinn, not sure if you could take a look at this quick PR to refine the names for some legacy error types? |
MaxGekk
approved these changes
Aug 9, 2024
|
+1, LGTM. Merging to master. |
IvanK-db
pushed a commit
to IvanK-db/spark
that referenced
this pull request
Sep 20, 2024
…172, _LEGACY_ERROR_TEMP_1173, and _LEGACY_ERROR_TEMP_1174 ### What changes were proposed in this pull request? Assign better name for error _LEGACY_ERROR_TEMP_1172, _LEGACY_ERROR_TEMP_1173, and _LEGACY_ERROR_TEMP_1174. ### Why are the changes needed? Proper name improves user experience with Spark SQL. ### Does this PR introduce _any_ user-facing change? Yes. ### How was this patch tested? Added new tests and ran all the tests in the suite: ``` org.apache.spark.sql.execution.datasources.parquetParquetSchemaSuite org.apache.spark.SparkThrowableSuite ``` ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47421 from junyuc25/SPARK-47261. Authored-by: junyuc25 <JunyuChen-0115@users.noreply.github.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…172, _LEGACY_ERROR_TEMP_1173, and _LEGACY_ERROR_TEMP_1174 ### What changes were proposed in this pull request? Assign better name for error _LEGACY_ERROR_TEMP_1172, _LEGACY_ERROR_TEMP_1173, and _LEGACY_ERROR_TEMP_1174. ### Why are the changes needed? Proper name improves user experience with Spark SQL. ### Does this PR introduce _any_ user-facing change? Yes. ### How was this patch tested? Added new tests and ran all the tests in the suite: ``` org.apache.spark.sql.execution.datasources.parquetParquetSchemaSuite org.apache.spark.SparkThrowableSuite ``` ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47421 from junyuc25/SPARK-47261. Authored-by: junyuc25 <JunyuChen-0115@users.noreply.github.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
…172, _LEGACY_ERROR_TEMP_1173, and _LEGACY_ERROR_TEMP_1174 ### What changes were proposed in this pull request? Assign better name for error _LEGACY_ERROR_TEMP_1172, _LEGACY_ERROR_TEMP_1173, and _LEGACY_ERROR_TEMP_1174. ### Why are the changes needed? Proper name improves user experience with Spark SQL. ### Does this PR introduce _any_ user-facing change? Yes. ### How was this patch tested? Added new tests and ran all the tests in the suite: ``` org.apache.spark.sql.execution.datasources.parquetParquetSchemaSuite org.apache.spark.SparkThrowableSuite ``` ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47421 from junyuc25/SPARK-47261. Authored-by: junyuc25 <JunyuChen-0115@users.noreply.github.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Assign better name for error _LEGACY_ERROR_TEMP_1172, _LEGACY_ERROR_TEMP_1173, and _LEGACY_ERROR_TEMP_1174.
Why are the changes needed?
Proper name improves user experience with Spark SQL.
Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
Added new tests and ran all the tests in the suite:
Was this patch authored or co-authored using generative AI tooling?
No