Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQL] remove a decimal case branch that has no effect at runtime #3192

Closed
wants to merge 1 commit into from
Closed

[SQL] remove a decimal case branch that has no effect at runtime #3192

wants to merge 1 commit into from

Conversation

mengxr
Copy link
Contributor

@mengxr mengxr commented Nov 10, 2014

it generates warnings at compile time @marmbrus

@SparkQA
Copy link

SparkQA commented Nov 10, 2014

Test build #23167 has started for PR 3192 at commit 955e9fb.

  • This patch merges cleanly.

@marmbrus
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented Nov 11, 2014

Test build #23167 has finished for PR 3192 at commit 955e9fb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23167/
Test PASSed.

@marmbrus
Copy link
Contributor

Thanks! Merged to master and 1.2

@asfgit asfgit closed this in d793d80 Nov 11, 2014
asfgit pushed a commit that referenced this pull request Nov 11, 2014
@mengxr @marmbrus
[SQL] remove a decimal case branch that has no effect at runtime
1ed1c68 
it generates warnings at compile time marmbrus

Author: Xiangrui Meng <meng@databricks.com>

Closes #3192 from mengxr/dtc-decimal and squashes the following commits:

955e9fb [Xiangrui Meng] remove a decimal case branch that has no effect

(cherry picked from commit d793d80)
Signed-off-by: Michael Armbrust <michael@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mengxr @SparkQA @marmbrus @AmplabJenkins