Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-4324] [PySpark] [MLlib] support numpy.array for all MLlib API #3189

Closed
wants to merge 2 commits into from
Closed

[SPARK-4324] [PySpark] [MLlib] support numpy.array for all MLlib API #3189

wants to merge 2 commits into from

Conversation

davies
Copy link
Contributor

@davies davies commented Nov 10, 2014

This PR check all of the existing Python MLlib API to make sure that numpy.array is supported as Vector (also RDD of numpy.array).

It also improve some docstring and doctest.

cc @mateiz @mengxr

@SparkQA
Copy link

SparkQA commented Nov 10, 2014

Test build #23160 has started for PR 3189 at commit 6987611.

  • This patch merges cleanly.

@mengxr
Copy link
Contributor

mengxr commented Nov 10, 2014

LGTM. Waiting for Jenkins...

@SparkQA
Copy link

SparkQA commented Nov 10, 2014

Test build #23160 has finished for PR 3189 at commit 6987611.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23160/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Nov 11, 2014

Test build #23178 has started for PR 3189 at commit d5057c4.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 11, 2014

Test build #23178 has finished for PR 3189 at commit d5057c4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23178/
Test PASSed.

@mengxr
Copy link
Contributor

mengxr commented Nov 11, 2014

Merged into master and branch-1.2. Thanks!

asfgit pushed a commit that referenced this pull request Nov 11, 2014
@mengxr
[SPARK-4324] [PySpark] [MLlib] support numpy.array for all MLlib API
df8242c 
This PR check all of the existing Python MLlib API to make sure that numpy.array is supported as Vector (also RDD of numpy.array).

It also improve some docstring and doctest.

cc mateiz mengxr

Author: Davies Liu <davies@databricks.com>

Closes #3189 from davies/numpy and squashes the following commits:

d5057c4 [Davies Liu] fix tests
6987611 [Davies Liu] support numpy.array for all MLlib API

(cherry picked from commit 65083e9)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@asfgit asfgit closed this in 65083e9 Nov 11, 2014
@davies davies deleted the numpy branch November 19, 2014 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davies @SparkQA @mengxr @AmplabJenkins