Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPARK-1344 [DOCS] Scala API docs for top methods #3168

Closed
wants to merge 1 commit into from
Closed

SPARK-1344 [DOCS] Scala API docs for top methods #3168

wants to merge 1 commit into from

Conversation

srowen
Copy link
Member

@srowen srowen commented Nov 8, 2014

Use "k" in javadoc of top and takeOrdered to avoid confusion with type K in pair RDDs. I think this resolves the discussion in SPARK-1344.

@SparkQA
Copy link

SparkQA commented Nov 8, 2014

Test build #23098 has started for PR 3168 at commit 6963fcc.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 8, 2014

Test build #23098 has finished for PR 3168 at commit 6963fcc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23098/
Test PASSed.

@squito
Copy link
Contributor

squito commented Nov 9, 2014

lgtm

@pwendell
Copy link
Contributor

Thanks I pulled this in.

@asfgit asfgit closed this in d136265 Nov 10, 2014
asfgit pushed a commit that referenced this pull request Nov 10, 2014
@srowen @pwendell
SPARK-1344 [DOCS] Scala API docs for top methods
a9debe8 
Use "k" in javadoc of top and takeOrdered to avoid confusion with type K in pair RDDs. I think this resolves the discussion in SPARK-1344.

Author: Sean Owen <sowen@cloudera.com>

Closes #3168 from srowen/SPARK-1344 and squashes the following commits:

6963fcc [Sean Owen] Use "k" in javadoc of top and takeOrdered to avoid confusion with type K in pair RDDs

(cherry picked from commit d136265)
Signed-off-by: Patrick Wendell <pwendell@gmail.com>
@srowen srowen deleted the SPARK-1344 branch November 11, 2014 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srowen @SparkQA @AmplabJenkins @squito @pwendell