-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite #28782
Changes from all commits
bb1efa2
1459d5b
88c40fe
df22083
0436611
ed80c84
39ca87c
c3b3c89
c3546eb
77a339a
a6b4f74
664277e
fd677c9
93b1f63
c4f9a62
0eec8ff
c7b81d2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -556,33 +556,27 @@ class HiveQuerySuite extends HiveComparisonTest with SQLTestUtils with BeforeAnd | |
assert(1 == res.getDouble(0)) | ||
} | ||
|
||
createQueryTest("timestamp cast #2", | ||
"SELECT CAST(CAST(1.2 AS TIMESTAMP) AS DOUBLE) FROM src LIMIT 1") | ||
|
||
test("timestamp cast #3") { | ||
val res = sql("SELECT CAST(CAST(1200 AS TIMESTAMP) AS INT) FROM src LIMIT 1").collect().head | ||
assert(1200 == res.getInt(0)) | ||
test("timestamp cast #2") { | ||
val res = sql("SELECT CAST(CAST(-1 AS TIMESTAMP) AS DOUBLE) FROM src LIMIT 1").collect().head | ||
assert(-1 == res.get(0)) | ||
} | ||
|
||
createQueryTest("timestamp cast #4", | ||
createQueryTest("timestamp cast #3", | ||
"SELECT CAST(CAST(1.2 AS TIMESTAMP) AS DOUBLE) FROM src LIMIT 1") | ||
|
||
createQueryTest("timestamp cast #4", | ||
"SELECT CAST(CAST(-1.2 AS TIMESTAMP) AS DOUBLE) FROM src LIMIT 1") | ||
|
||
test("timestamp cast #5") { | ||
val res = sql("SELECT CAST(CAST(-1 AS TIMESTAMP) AS DOUBLE) FROM src LIMIT 1").collect().head | ||
assert(-1 == res.get(0)) | ||
val res = sql("SELECT CAST(CAST(1200 AS TIMESTAMP) AS INT) FROM src LIMIT 1").collect().head | ||
assert(1200 == res.getInt(0)) | ||
} | ||
|
||
createQueryTest("timestamp cast #6", | ||
"SELECT CAST(CAST(-1.2 AS TIMESTAMP) AS DOUBLE) FROM src LIMIT 1") | ||
|
||
test("timestamp cast #7") { | ||
test("timestamp cast #6") { | ||
val res = sql("SELECT CAST(CAST(-1200 AS TIMESTAMP) AS INT) FROM src LIMIT 1").collect().head | ||
assert(-1200 == res.getInt(0)) | ||
} | ||
|
||
createQueryTest("timestamp cast #8", | ||
"SELECT CAST(CAST(-1.2 AS TIMESTAMP) AS DOUBLE) FROM src LIMIT 1") | ||
|
||
Comment on lines
-583
to
-585
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, we can rename them to make it prettier. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1 |
||
createQueryTest("select null from table", | ||
"SELECT null FROM src LIMIT 1") | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, as you suggested, the test looks duplicate. cc: @HyukjinKwon @viirya
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks duplicate.